Skip to content

Conversation

@jbampton
Copy link
Member

Description

This PR cleans up some Python code. Mainly print statements.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added the Python Warning... Python code Ahead! label Apr 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.06%. Comparing base (b1ba9bf) to head (3dc23bc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8993   +/-   ##
=========================================
  Coverage     16.06%   16.06%           
  Complexity    12872    12872           
=========================================
  Files          5642     5642           
  Lines        493953   493953           
  Branches      59889    59889           
=========================================
  Hits          79351    79351           
  Misses       405817   405817           
  Partials       8785     8785           
Flag Coverage Δ
uitests 4.01% <ø> (ø)
unittests 16.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9448

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and not sure if anybody is using the ovm3 plugin so low risk addition. No testing possible as far as I know. This probably the reason it wasa left behind as well.

@jbampton
Copy link
Member Author

jbampton commented Jul 8, 2024

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10278

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11337

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, but this plugin should be deprecated. cc @JoaoJandre ?

Copy link
Contributor

@JoaoJandre JoaoJandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I'm not sure on the current status of ovm. But we could start a thread on the mailing lists to see if anyone still uses it. If not, we can deprecate it and eventually remove it in the next major version (we really need to agree on a way to release the next major).

@DaanHoogland DaanHoogland force-pushed the python-2-to-3-clean-up branch from e0ea499 to eb4efca Compare October 23, 2024 19:21
@DaanHoogland DaanHoogland added this to the 4.21.0.0 milestone Oct 24, 2024
@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11871

@DaanHoogland DaanHoogland merged commit ee893d1 into apache:main Dec 23, 2024
26 checks passed
@jbampton jbampton deleted the python-2-to-3-clean-up branch December 25, 2024 07:09
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Python Warning... Python code Ahead!

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants