BEANUTILS-515: Java 8 Time converters.#13
Merged
garydgregory merged 4 commits intoapache:masterfrom Oct 22, 2019
melloware:BEANUTILS-515
Merged
BEANUTILS-515: Java 8 Time converters.#13garydgregory merged 4 commits intoapache:masterfrom melloware:BEANUTILS-515
garydgregory merged 4 commits intoapache:masterfrom
melloware:BEANUTILS-515
Conversation
Contributor
melloware
commented
Oct 22, 2019
melloware
commented
- java.time.LocalDate
- java.time.LocalDateTime
- java.time.OffsetDateTime
- java.time.ZonedDateTime
Member
|
Please rebase on master to see if the -e on the mvn invocation gives us a better error message for the Java 12 build. |
Display better error message for failing build.
Contributor
Author
|
Trying now... |
Contributor
Author
|
Whatever you did it magically fixed it. |
Member
|
I just added "-e" to the mvn invocation. Any thoughts on covering the other java.time classes? |
Contributor
Author
|
Yes I will submit another PR. I didn’t want to overwhelm in 1 PR! |
Member
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.