Closed
Conversation
Member
|
@dhruvdk7 |
Author
|
Hey there.....Sorry for the inconvenience
There were design smells in the code. I identified 3 implementation smells
and 2 design smell. For the move method Refractoring I have removed the
feature envy smell . It was 13 earlier and now it is 12.
Awaiting for your reply,
Dhruv Kothari
…On Fri, Apr 7, 2023 at 11:30 AM Gary Gregory ***@***.***> wrote:
@dhruvdk7 <https://github.com/dhruvdk7>
This PR has no description and its title is meaningless. What are you
trying to do?
—
Reply to this email directly, view it on GitHub
<#173 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOLLROO6NHIXOPN7PM4P7NDXAAQJ7ANCNFSM6AAAAAAWWDTGCA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
garydgregory
requested changes
Aug 14, 2023
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
You can't remove public or protected code as it will break binary compatibility. Java type names start with a capital letter.
Member
|
Closing: No reply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.