[CLI-326] Make Option.getKey() public#239
Merged
garydgregory merged 3 commits intoapache:masterfrom Feb 29, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
============================================
+ Coverage 91.90% 92.09% +0.19%
- Complexity 575 592 +17
============================================
Files 22 22
Lines 1247 1265 +18
Branches 210 211 +1
============================================
+ Hits 1146 1165 +19
+ Misses 63 60 -3
- Partials 38 40 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * @return the 'unique' Option identifier | ||
| */ | ||
| String getKey() { | ||
| public String getKey() { |
Member
There was a problem hiding this comment.
Hello @Claudenw
If you make an element public or protected, you need a @since Javadoc tag.
sebbASF
reviewed
Feb 27, 2024
| * @return the 'unique' Option identifier | ||
| */ | ||
| String getKey() { | ||
| public String getKey() { |
Contributor
There was a problem hiding this comment.
It also needs more Javadoc to explain what the key means
Member
|
@Claudenw ping |
Contributor
Author
|
at a conference today. Will try to get to this. |
garydgregory
added a commit
that referenced
this pull request
Feb 29, 2024
garydgregory
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for CLI-326