Fix possible ArrayIndexOutOfBoundsException#218
Closed
arthurscchan wants to merge 1 commit intoapache:masterfrom
Closed
Fix possible ArrayIndexOutOfBoundsException#218arthurscchan wants to merge 1 commit intoapache:masterfrom
arthurscchan wants to merge 1 commit intoapache:masterfrom
Conversation
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a possible ArrayIndexOutOfBoundException in src/main/java/org/apache/commons/codec/language/QuotedPrintableCodec.java
The
encodeQuotedPrintable()method takes in a random byte array and processes it. If the providedstrictboolean is true, it will go into the first branch. There is a for loop to loop through the byte array from the index 0 to the index byte.length - 3. The index is then used directly ingetUnsignedOctetmethod If the length of the byte array is less than 3, it will result in a negative index and cause ArrayIndexOutOfBoundsException ingetUnsignedOctet()method call.This PR adds a conditional check to ensure the index is never negative. It will simply return null if the byte array is too short (with a length less than 3) if
strictvalue is true.We found this bug using fuzzing by way of OSS-Fuzz. It is reported at https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64358.