[COLLECTIONS-663] Update AbstractMultiValuedMap asMap() #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dota17
force-pushed
the
AbstractMultiValuedMap
branch
from
311980a to
d63a3ca
Compare
garydgregory
requested changes
Apr 29, 2020
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
See my inline comment, other assert changes look good. TY.
| final K key = entry.getKey(); | ||
| return new UnmodifiableMapEntry<>(key, wrappedCollection(key)); | ||
| final Collection<V> value = entry.getValue(); | ||
| return new UnmodifiableMapEntry<>(key, value); |
Member
There was a problem hiding this comment.
You can just inline key and value IMO.
dota17
force-pushed
the
AbstractMultiValuedMap
branch
from
82e7f01 to
58ec415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[COLLECTIONS-663] https://issues.apache.org/jira/browse/COLLECTIONS-663
Hi:
I think the representation of Multimap is {1: A, 1: B, 2: C}. So when A and B are deleted, only {2: C} is left. And asMap() method returns a map in the form of {1：[A, B], 2：[C]}. In this map, {1：[], 2:[C]} is left when A and B are deleted. So wrappedCollection(key) should not be used。 It willl show as {1: A, 1: B, 2: C} when wrappedCollection(key) is used, and the asMap() method does not make sense.