Merged
Conversation
Configuration has been added based on commons-lang. The Apache licence header has been added to the checkstyle config.
Add missing newlines at end of files. Remove redundant modifiers. Fix incorrect Apache license header. Fix whitespace around elements. Remove tab characters. Fix right-curly location. Correct modifier order.
Changed rules to be more lenient on tests.
aherbert
force-pushed
the
update-checkstyle
branch
2 times, most recently
from
79fcc1f to
fa276dc
Compare
Fixed all code. Case statements have an indent of zero as recommended by Oracle. Previously the code was using either 0 or 4 as the indent. Using zero for the check has fewer violations that require fixing.
This was the original level before update of checkstyle config.
aherbert
force-pushed
the
update-checkstyle
branch
from
fa276dc to
ad04fff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated checkstyle using commons lang as a template.
Fixed code in main and test to conform. The exclusions are updated to allow tests to ignore some rules.
Added checkstyle:check to the default goal.