Skip to content

Conversation

@Claudenw
Copy link
Contributor

fix for COLLECTIONS-763

Removes constructors that initialze the BloomFilter with data via the Hasher argument to the constructor. The exception is the HasherBloomFilter which by definition wraps a Hasher.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 90.087% when pulling 51f744a on Claudenw:BloomFilter_constructor_mod_for_763 into 9f37668 on apache:master.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if it has already been released, then we have to wait for a major version release in order to keep backward compatibility?

@garydgregory garydgregory merged commit 0d10d91 into apache:master Nov 20, 2020
@Claudenw Claudenw deleted the BloomFilter_constructor_mod_for_763 branch June 16, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants