[COLLECTIONS-778] - Use assertThrows#206
Closed
arturobernalg wants to merge 1 commit intoapache:masterfrom
arturobernalg:feature/COLLECTIONS-778
Closed
[COLLECTIONS-778] - Use assertThrows#206arturobernalg wants to merge 1 commit intoapache:masterfrom arturobernalg:feature/COLLECTIONS-778
arturobernalg wants to merge 1 commit intoapache:masterfrom
arturobernalg:feature/COLLECTIONS-778
Conversation
kinow
approved these changes
Jan 13, 2021
Member
kinow
left a comment
kinow
left a comment
There was a problem hiding this comment.
Great work! Change looks good to me, JIRA issue updated, GH actions build passed (not worrying about Travis that is still running).
Thanks a lot @arturobernalg !
Bruno
Member
Author
|
Thank you @kinow Glad to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change old way expected = Exception with Junit5 way assertThrows