COLLECTIONS-786: fix PassiveExpiringMap documentation#237
Closed
vandrewskis wants to merge 1 commit intoapache:masterfrom
Closed
COLLECTIONS-786: fix PassiveExpiringMap documentation#237vandrewskis wants to merge 1 commit intoapache:masterfrom
vandrewskis wants to merge 1 commit intoapache:masterfrom
Conversation
kinow
approved these changes
May 22, 2021
Member
kinow
left a comment
kinow
left a comment
There was a problem hiding this comment.
Hi @vandrewskis
Thanks for the PR. I agree with the issue description and with the patch here. Both containsValue and entrySet call removeAllExpired(now()); which iterates all elements as the Javadoc says. While containsKey does not.
size also calls that, but it's part of the "etc" :-) so no need to include.
+1
Member
|
Added changelog, updated JIRA fixVersion, merged. Thanks!! |
Contributor
Author
|
@kinow , thanks for review and merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
containsKeydoes not access entire map, whilecontainsValuedoes