Test cases for iterators package, map package, and collection4 package #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keval-Gandevia
commented
Mar 3, 2024
Keval-Gandevia
commented
- For EnumerationIterator.java in org.apache.commons.collections4.iterators
- A test case for remove method is added.
- For ListIteratorWrapper.java in org.apache.commons.collections4.iterators
- A test case for add method is added.
- For UnmodifiableEntrySet.java in org.apache.commons.collections4.map
- A test case for toArray method is added.
- For ArrayStack.java in org.apache.commons.collections4
- A test case for peek method is added.
garydgregory
requested changes
Mar 3, 2024
Member
There was a problem hiding this comment.
Hello @Keval-Gandevia
Thank you for your PR.
Please see my comments.
Run mvn by itself and fix the current build errors.
| // check for valid index | ||
| assertEquals("Second", stack.peek(1)); | ||
| // check for invalid index | ||
| assertThrows(EmptyStackException.class, () -> {stack.peek(5);}); |
Member
There was a problem hiding this comment.
Lambda block is not needed.
| // check for invalid index | ||
| assertThrows(EmptyStackException.class, () -> {stack.peek(5);}); | ||
| // check if stack is empty. | ||
| assertThrows(EmptyStackException.class, () -> {emptyStack.peek(1);}); |
Member
There was a problem hiding this comment.
Lambda block is not needed.
| @Test | ||
| public void testRemove() { | ||
| // arrange | ||
| List<String> list = new ArrayList<>(Arrays.asList("First", "Second", "Third")); |
| import org.apache.commons.collections4.map.UnmodifiableEntrySet; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.*; |
Member
There was a problem hiding this comment.
Please don't change the import style, we do not use star imports.
| @Test | ||
| public void testToArray() { | ||
| // arrange | ||
| Set<Map.Entry<K, V>> x = makeCustomFullMap(); |
| */ | ||
| package org.apache.commons.collections4.iterators; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; |
Member
There was a problem hiding this comment.
Please don't change the import style, we do not use star imports.
| // arrange part starts | ||
| final ResettableListIterator<E> iter1 = makeCustomObject(); | ||
| final ResettableListIterator<E> iter2 = makeObject(); | ||
| int[] x = new int[]{1}; |
|
|
||
| // act and assert starts | ||
| // check for no exception | ||
| assertDoesNotThrow(()->{iter1.add((E) x);}); |
Member
There was a problem hiding this comment.
Missing space around arrow, block not needed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
============================================
+ Coverage 81.60% 81.81% +0.21%
- Complexity 4745 4758 +13
============================================
Files 295 295
Lines 13751 13751
Branches 2022 2022
============================================
+ Hits 11222 11251 +29
+ Misses 1929 1899 -30
- Partials 600 601 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.