Added additional tests for map classes based on mutation results#87
Merged
garydgregory merged 1 commit intoapache:masterfrom Oct 12, 2019
adwiii:master
Merged
Added additional tests for map classes based on mutation results#87garydgregory merged 1 commit intoapache:masterfrom adwiii:master
garydgregory merged 1 commit intoapache:masterfrom
adwiii:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used this project as a learning tool for getting familiar with Pitest mutation testing and picked a few test classes to improve based on the result. I picked the below classes because the current test suite provides 100% line coverage, but PIT found surviving mutants.
Transformed Map
In the
TransformedMapTestclass, thetestFactory_decorateTransformmethod did not provide a key transformer. InTransformedMap::transformedMapthe call todecorated.clear()is only necessary if the key transformer changes the key set. This adds a test with a key transformer.Lazy Sorted Map and Predicated Map
Both
LazySortedMapandPredicatedMaphave tests that check if the comparator is null, but never check for a non-null value. The added tests check that if a non-null comparator is used then it is properly returned.