COMPRESS-407: Allow use of invalid record sizes if a system property is set.#42
Closed
sesuncedu wants to merge 2 commits into
Closed
COMPRESS-407: Allow use of invalid record sizes if a system property is set.#42sesuncedu wants to merge 2 commits into
sesuncedu wants to merge 2 commits into
Conversation
Require block size >=0 that is multiple of 512 bytes. Use block size of 512 if one is not given. Require record size of 512 bytes. Deprecate constructors taking recordSize as parameter Modify tests to check for enforcement of record size == 512 Modify tests to check for correct overall length for different block sizes including PAX default, USTAR default, and unspecified. Signed-off-by: Simon Spero <sesuncedu@gmail.com> (cherry picked from commit d754d89) Signed-off-by: Simon Spero <sesuncedu@gmail.com>
… them through if a system property is set. Signed-off-by: Simon Spero <sesuncedu@gmail.com>
Contributor
Author
|
The system property is can be discovered by reading the source code. This information could be added to the exception message. |
sesuncedu
pushed a commit
to sesuncedu/commons-compress
that referenced
this pull request
Jun 24, 2017
sesuncedu
pushed a commit
to sesuncedu/commons-compress
that referenced
this pull request
Jun 25, 2017
sesuncedu
pushed a commit
to sesuncedu/commons-compress
that referenced
this pull request
Jun 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not recommend using this approach. #40 is the preferred solution.