Skip to content

Conversation

@boyarsky
Copy link
Contributor

@boyarsky boyarsky commented Jul 1, 2018

Files.newInputStream is a static method so the "new" keyword shouldn't be here.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 86.368% when pulling 6d8e716 on boyarsky:master into 22b0d06 on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 86.368% when pulling 6d8e716 on boyarsky:master into 22b0d06 on apache:master.

@boyarsky
Copy link
Contributor Author

boyarsky commented Jul 1, 2018

Note: Some of the Travis builds failed for a reason unrelated to my change. (And had been failing from before my change). Also, the coverage decrease was not due to my change either. My change was only in the docs.

Not sure what convention is here so just documenting these facts.

@asfgit asfgit closed this in 1478499 Jul 1, 2018
@bodewig
Copy link
Member

bodewig commented Jul 1, 2018

Merged, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants