Avoid NPE when combined location strategy sub strategies is immutable…#639
Merged
Merged
Conversation
Contributor
Author
|
|
| final Collection<FileLocationStrategy> collectionThatThrowsNPE = new ArrayList<FileLocationStrategy>(Arrays.asList(getSubStrategies())) { | ||
| @Override | ||
| public boolean contains(Object o) { | ||
| if (o == null) { |
Member
There was a problem hiding this comment.
This is a test, use assertNotNull().
| @Override | ||
| public boolean contains(Object o) { | ||
| if (o == null) { | ||
| throw new NullPointerException("Collection does not support null"); |
Member
There was a problem hiding this comment.
Use Objects.requireNonNull().
| // Create a collection that throws NPE on contains(null) like ImmutableList does | ||
| final Collection<FileLocationStrategy> collectionThatThrowsNPE = new ArrayList<FileLocationStrategy>(Arrays.asList(getSubStrategies())) { | ||
| @Override | ||
| public boolean contains(Object o) { |
| */ | ||
| @Test | ||
| void testInitCollectionThrowsNPEOnContainsNull() { | ||
| // Create a collection that throws NPE on contains(null) like ImmutableList does |
Member
There was a problem hiding this comment.
Whose ImmutableList? Don't you mean implementations like java.util.ImmutableCollections.List12.indexOf(Object)?
Contributor
Author
There was a problem hiding this comment.
Yes, I've slightly updated the comment.
Member
You are correct, these Javadoc warning occur in generated code and we are ignoring them for now. |
Member
|
Hello @weih-kahoot You MUST run TY! |
Contributor
Author
|
@garydgregory Sorry, I forgot that. I have pushed another commit to fix checkstyle errors(we should squash my commits before merging). |
Member
I normally squash before a merge but that's something you can also do on your end. |
weih-kahoot
force-pushed
the
avoid-immutable-list-npe
branch
from
f33cfbf to
0733706
Compare
Contributor
Author
|
@garydgregory Okay, I've squashed my commits |
garydgregory
added a commit
that referenced
this pull request
May 21, 2026
garydgregory
added a commit
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our project, we use CombiendLocationStrategy(List.of(...)), this will result a NPE as List#contains will be called for the passed-in immutable list instance.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.