CRYPTO-7: Rename source code in Chimera to Apache name space#5
Closed
winningsix wants to merge 2 commits intoapache:masterfrom
Closed
CRYPTO-7: Rename source code in Chimera to Apache name space#5winningsix wants to merge 2 commits intoapache:masterfrom
winningsix wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
+1 |
README.md
Outdated
|
|
||
| ``` | ||
| libraryDependencies += "com.intel.chimera" % "chimera" % "0.9.0" | ||
| libraryDependencies += "org.apache.commons.crypto" % "chimera" % "0.9.0" |
Contributor
There was a problem hiding this comment.
Please note there is still a "chimera" in the name part. If this change for only package name, please describe this specifically in the JIRA.
Make a note for this instance so that we remember change it in the future.
Contributor
|
Thanks @winningsix for the patch. I have made some comments. If you don't intend to address some naming in this pull request, please make sure to create another JIRA to record that fact that we need to take another action. |
Contributor
|
LGTM. Let's create separate JIRAs to address other naming changes. |
Contributor
Author
|
This has been committed to the upstream. Thanks @jerrychenhf @kexianda for your reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://issues.apache.org/jira/browse/CRYPTO-7
Please notice we only change the package name and didn't update the configuration and README parts.