CRYPTO-127: CryptoInputStream#read should handle non-block case#72
Closed
kexianda wants to merge 1 commit intoapache:masterfrom
Closed
CRYPTO-127: CryptoInputStream#read should handle non-block case#72kexianda wants to merge 1 commit intoapache:masterfrom
kexianda wants to merge 1 commit intoapache:masterfrom
Conversation
sundapeng
reviewed
Nov 7, 2016
| nd = decryptMore(); | ||
| } | ||
| if (nd < 0) { | ||
| return nd; |
Member
There was a problem hiding this comment.
if we want to change to loop here, the return value should also be updated.
Contributor
Author
There was a problem hiding this comment.
@sundapeng
Hmm..., it seems OK now.
It's would be better if we add some testcases in future
Member
There was a problem hiding this comment.
Yes, I think it should be okay, I misunderstood it.
Member
|
Thank Xianda for the contribution, I have only one comment. |
Member
|
+1 |
Member
|
Thank @kexianda |
asfgit
pushed a commit
that referenced
this pull request
Nov 21, 2016
Closes #72 from jianguotian/CRYPTO-129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.