Skip to content

Conversation

@RHSaliya
Copy link

@RHSaliya RHSaliya commented Apr 6, 2023

I'm learning how to contribute to open-source projects. This is my first pull request. So, I have not made major changes.

@codecov-commenter
Copy link

Codecov Report

Merging #319 (0f20f4a) into master (1842b78) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #319   +/-   ##
=========================================
  Coverage     97.87%   97.87%           
  Complexity      549      549           
=========================================
  Files            11       11           
  Lines          1178     1178           
  Branches        204      204           
=========================================
  Hits           1153     1153           
  Misses           13       13           
  Partials         12       12           
Impacted Files Coverage Δ
...rc/main/java/org/apache/commons/csv/CSVFormat.java 98.02% <100.00%> (ø)
...c/main/java/org/apache/commons/csv/CSVPrinter.java 95.78% <100.00%> (ø)
...rc/main/java/org/apache/commons/csv/Constants.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garydgregory
Copy link
Member

This looks like a change for change's sake, without explanation, so -1 from me.

@RHSaliya
Copy link
Author

RHSaliya commented Apr 6, 2023

Sorry, I will make more changes and make a pull request.

@garydgregory
Copy link
Member

Hi @RHSaliya
-1: sorry but this looks like changes for changes sake.
You can look at Jira for bug reports and feature requests.

@garydgregory
Copy link
Member

Closing: no reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants