Skip to content

[CSV-325] CSVParser applies characterOffset to bytePosition#604

Merged
garydgregory merged 1 commit into
apache:masterfrom
garydgregory:fix/CSV-325_CSVParser_setByteOffset
May 22, 2026
Merged

[CSV-325] CSVParser applies characterOffset to bytePosition#604
garydgregory merged 1 commit into
apache:masterfrom
garydgregory:fix/CSV-325_CSVParser_setByteOffset

Conversation

@garydgregory
Copy link
Copy Markdown
Member

[CSV-325] CSVParser applies characterOffset to bytePosition, breaking getBytePosition() for multi-byte prefixes

Add CSVParser.Builder.setByteOffset(long)

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

breaks getBytePosition() for multi-byte prefixes

Add CSVParser.Builder.setByteOffset(long)
@garydgregory garydgregory merged commit 3750064 into apache:master May 22, 2026
14 checks passed
@garydgregory garydgregory deleted the fix/CSV-325_CSVParser_setByteOffset branch May 22, 2026 11:54
garydgregory added a commit that referenced this pull request May 22, 2026
getBytePosition() for multi-byte prefixes.

Add CSVParser.Builder.setByteOffset(long) (#604).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant