Minor Improvements#22
Merged
garydgregory merged 13 commits intoapache:masterfrom Feb 6, 2021
arturobernalg:feature/minor_improvement
Merged
Minor Improvements#22garydgregory merged 13 commits intoapache:masterfrom arturobernalg:feature/minor_improvement
garydgregory merged 13 commits intoapache:masterfrom
arturobernalg:feature/minor_improvement
Conversation
Member
arturobernalg
commented
Jan 19, 2021
arturobernalg
commented
- Add final
- Remove redundant initializer
- Replace String in loop by StringBuilder
- Use Empty array
* Add final * Remove redundant initializer * Replace String in loop by StringBuilder * Use Empty array
garydgregory
reviewed
Feb 5, 2021
| private final Invoker shutdown; | ||
|
|
||
| /** | ||
| * An empty immutable {@code String} array. |
Member
There was a problem hiding this comment.
This does not need to be public does it?
garydgregory
reviewed
Feb 5, 2021
src/main/java/org/apache/commons/daemon/support/DaemonConfiguration.java
Show resolved
Hide resolved
Member
|
Also please rebase on master to pick up the GitHub build addition. |
Otherwise it might wait for ever and the processes have to be kill by hands.
garydgregory
reviewed
Feb 5, 2021
| System.err.println("SimpleDaemon: instance "+this.hashCode()+ | ||
| " created"); | ||
| this.handlers=new Vector<Handler>(); | ||
| this.HANDLERS =new Vector<Handler>(); |
garydgregory
approved these changes
Feb 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.