[DBCP-520] BasicManagedDataSource needs to pass the TSR with creating DataSourceXAConnectionFactory#18
Closed
zhfeng wants to merge 2 commits intoapache:masterfrom
Closed
[DBCP-520] BasicManagedDataSource needs to pass the TSR with creating DataSourceXAConnectionFactory#18zhfeng wants to merge 2 commits intoapache:masterfrom
zhfeng wants to merge 2 commits intoapache:masterfrom
Conversation
creating the DataSourceXAConnectionFactory
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
Is it possible to add a unit test for this? It looks like there also was a password issue?
Contributor
Author
|
@garydgregory yeah, I add a test and I'm not sure the password issue with the CI test. I can not reproduce it locally. |
Contributor
Author
|
@garydgregory I had added the unit test and the travis CI looks good. So is it OK to merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/DBCP-520