[DBCP-547] Add a ConnectionFactory interface in BasicDataSource.createConnectionFactory()#32
Closed
leechoongyon wants to merge 4 commits intoapache:masterfrom
Closed
[DBCP-547] Add a ConnectionFactory interface in BasicDataSource.createConnectionFactory()#32leechoongyon wants to merge 4 commits intoapache:masterfrom
leechoongyon wants to merge 4 commits intoapache:masterfrom
Conversation
added 4 commits
July 3, 2019 15:06
BasicDataSource.createConnectionFactory()
BasicDataSource.createConnectionFactory().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DBCP-547] Add a ConnectionFactory interface in BasicDataSource.createConnectionFactory()
I think it would be nice better to implement a ConnectionFactory interface in BasicDataSource class.
In my current project, when getting a connection in my program, I call oracleSetModule.
so, i think that after creating connection, call oracleSetModule via connectionFactoryImpl seems to be nice.
This reduces the cost of calling oracleSetModule when calling BasicDataSource.getConnection().