JUnit5 assertThrows DataSourceUrlResolverTest#107
Closed
nhojpatrick wants to merge 2 commits intoapache:masterfrom
Closed
JUnit5 assertThrows DataSourceUrlResolverTest#107nhojpatrick wants to merge 2 commits intoapache:masterfrom
nhojpatrick wants to merge 2 commits intoapache:masterfrom
Conversation
nhojpatrick
force-pushed
the
junit5-assertThrows-DataSourceUrlResolverTest
branch
from
cc2a8b1 to
44650f5
Compare
garydgregory
requested changes
Nov 12, 2022
src/test/java/org/apache/commons/mail/resolver/DataSourceUrlResolverTest.java
Outdated
Show resolved
Hide resolved
nhojpatrick
force-pushed
the
junit5-assertThrows-DataSourceUrlResolverTest
branch
from
44650f5 to
265883f
Compare
garydgregory
requested changes
Nov 25, 2022
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
Please inline the local variables that hold lambdas.
nhojpatrick
force-pushed
the
junit5-assertThrows-DataSourceUrlResolverTest
branch
from
265883f to
0f79590
Compare
Contributor
Author
|
@garydgregory doh i thought i had done that in the last rebase and push |
Member
|
-1 test fails |
Member
|
Closing: TY @nhojpatrick, in git master, differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.