Do not automatically encode attachment's filename #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@markt-asf any reason why is this closed? Current behavior is erroneous in some circumstances. |
|
The PR was against trunk |
Author
|
@markt-asf I see, thank you, will update it. |
Author
|
@markt-asf Updated and also added one commit, tests pass now. |
As of javax.mail 1.5.6, javax.mail.internet.MimeBodyPart contains the method static void setFileName(MimePart part, String name) that allows user to choose to encode the filename by MimeUtility.encodeText(name). Automatically encoding of filename should not be done in commons-email, but in javax.mail. See issue https://issues.apache.org/jira/browse/EMAIL-138
Author
|
Squashed commits to one, this PR should be good to go, if approved. |
vipenti
added a commit
to vipenti/commons-email
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of javax.mail 1.5.6,
javax.mail.internet.MimeBodyPartcontains the methodstatic void setFileName(MimePart part, String name)that allows user to choose to encode the filename by
MimeUtility.encodeText(name). Automatically encoding of filename should not be done in commons-email, but in javax.mail.See issue EMAIL-138