OSGi metadata enhancements#233
Conversation
- Versioned imports - OSGi contract for JakartaServlet / JavaServlet - 'javax.portlet' only in 'commons-fileupload2-portlet' - Link to Jakarta EE docs Signed-off-by: Michael H. Siemaszko <mhs@into.software>
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-fileupload2</artifactId> | ||
| <version>2.0.0-M2-SNAPSHOT</version> | ||
| <version>2.0.0-M3-SNAPSHOT</version> |
There was a problem hiding this comment.
Don't change the version please.
There was a problem hiding this comment.
Despite the changes, you'd like to leave this at 2.0.0-M2 ? Or you want to change the version yourself?
There was a problem hiding this comment.
2.0.0-M2 will be the next release, 2.0.0-M2-SNAPSHOT is the temporary version until the release. Don't change any of these versions in the poms.
There was a problem hiding this comment.
I had to change version as artifacts were modified and that change needed to be reflected via version change / I needed to refer to those particular modified artifacts.. Those artifacts are already used in internal projects.
Do you want me to change those versions for you just for this PR or do you mind changing those back to M2 when you merge it, as I see you as author of all commits @ https://github.com/apache/commons-fileupload/commits/master (at least first several pages) anyway ?
|
Let's keep it simple: If you want this PR merged, l'll ask for the 3rd time, don't change the versions. |
|
Please change your tone and answer questions asked. I explained in detail why versions were updated. There are multiple, much bigger projects which depend on this. You'll have to change the versions yourself if this is such a problem. OSGi metadata is wrong or completely missing, hence this PR - do as you please, I will not have ridiculous discussions about version changes where artifacts change and versions must be updated, definitely not in this tone and omitting questions I ask. |
|
In git master without version changes. |
2 participants
As a follow up to #232, and subsequent 33a8b55 commit, which split Jakarta Servlet support into separate modules, here’s PR which focuses solely on OSGi metadata enhancements (and fixes), i.e.: