Fix off-by-one error when checking fileSizeMax in FileItemInputImpl#235
Merged
garydgregory merged 1 commit intoapache:masterfrom Aug 15, 2023
Merged
Conversation
garydgregory
changed the title
garydgregory
added a commit
that referenced
this pull request
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
onMaxLengthmethod ofBoundedInputStreamtriggers when themaxLengthis met or exceeded, and we want to throw an exception only when it is exceeded. To fix this, thefileSizeMaxattribute is incremented before being passed to the bounded stream.I've added tests to check the cases where the
fileSizeMaxequals the length of the stream, and where the length of the stream is one greater. Let me know if I need to file a JIRA issue to go along with this.