GEOMETRY-119: adding Vector.normalizeOrNull() method#143
Merged
asfgit merged 1 commit intoapache:masterfrom Apr 9, 2021
Merged
GEOMETRY-119: adding Vector.normalizeOrNull() method#143asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
arturobernalg
approved these changes
Apr 2, 2021
commons-geometry-core/src/main/java/org/apache/commons/geometry/core/Vector.java
Outdated
Show resolved
Hide resolved
Contributor
|
IMO, it shouldn't return |
Contributor
Author
|
@singhbaljit, that's a good idea. Can you suggest that on the JIRA issue along with what you think we should name the method? Would it still be "normalizeOrNull"? |
darkma773r
force-pushed
the
geometry-119-normalize-or-null
branch
from
ac004ec to
de88266
Compare
darkma773r
changed the title
darkma773r
force-pushed
the
geometry-119-normalize-or-null
branch
from
de88266 to
7242fd2
Compare
darkma773r
changed the title
aherbert
reviewed
Apr 7, 2021
Contributor
aherbert
left a comment
aherbert
left a comment
There was a problem hiding this comment.
Hi @darkma773r, just a few nitpicks to address here.
...-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java
Outdated
Show resolved
Hide resolved
...-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java
Show resolved
Hide resolved
...ns-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Vector2D.java
Outdated
Show resolved
Hide resolved
...metry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java
Outdated
Show resolved
Hide resolved
...eometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java
Outdated
Show resolved
Hide resolved
...eometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java
Show resolved
Hide resolved
...metry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java
Show resolved
Hide resolved
…s if needed during normalization
darkma773r
force-pushed
the
geometry-119-normalize-or-null
branch
from
7242fd2 to
ea68dfb
Compare
Contributor
Author
|
Updated. Thanks, @aherbert! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.