[IO-669] Fix code smells; fix typos#115
Conversation
|
Also, in function NullPrintStreamTest.process(final NullPrintStream nos), |
I just started a release candidate for 2.7 so this will have to wait until another RC if something goes wrong or more likely the next release. The API you refer to is defined in Java 8 as |
OK, none of them is bugfix nor other important things so you can review/merge it anytime you want sooner or later.
I will find some time to test if j2se8 can run jdk14's compile output NullPrintStreamTest classfile. |
XenoAmess
changed the title
| return String.format("%,d files, %,d directories, %,d bytes", Long.valueOf(fileCounter.get()), | ||
| Long.valueOf(directoryCounter.get()), Long.valueOf(byteCounter.get())); | ||
| return String.format("%,d files, %,d directories, %,d bytes", fileCounter.get(), | ||
| directoryCounter.get(), byteCounter.get()); |
There was a problem hiding this comment.
Same comment as in your other PR. Let's leave boxing and unboxing as obvious since we are in a low level library and I prefer to see where this happens so we can think about consequences of creating objects.
There was a problem hiding this comment.
OK, will not happen next time :-)
| final IOFileFilter filter = FileFilterUtils.trueFileFilter(); | ||
| try { | ||
| FileFilterUtils.filterList(filter, Arrays.asList((File) null)); | ||
| FileFilterUtils.filterList(filter, Collections.singletonList((File) null)); |
There was a problem hiding this comment.
It is worth testing both kinds?
There was a problem hiding this comment.
@garydgregory it is only used as a Iterable there thus I think it has no actual difference IMO, exluding running speed.
garydgregory
changed the title
3 participants
https://issues.apache.org/jira/browse/IO-669