IO-727: FilenameUtils directoryContains() should handle files with the same prefix #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trgpa
force-pushed
the
IO-727-directoryContains
branch
from
089603e to
8d4bb52
Compare
Member
|
@trungPa |
trgpa
force-pushed
the
IO-727-directoryContains
branch
2 times, most recently
from
8d4bb52 to
1e8b502
Compare
garydgregory
reviewed
Sep 3, 2021
src/test/java/org/apache/commons/io/FileUtilsDirectoryContainsTestCase.java
Show resolved
Hide resolved
garydgregory
changed the title
trgpa
force-pushed
the
IO-727-directoryContains
branch
from
1e8b502 to
797e715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilenameUtils.directoryContains. Add a file separator to the end of the parent directory to avoid treating files having the same prefix as subdirectories.directoryContainswill return false when either parent or child is empty.testIO466with a new test case to demonstrate the bug (the currenttestIO466will always pass because fooFile doesn't exist)Jira: https://issues.apache.org/jira/browse/IO-727