Simplified res closing and prevented creating/closing process OutputS…#427
Closed
tbw777 wants to merge 1 commit intoapache:masterfrom
tbw777:twr
Closed
Simplified res closing and prevented creating/closing process OutputS…#427tbw777 wants to merge 1 commit intoapache:masterfrom tbw777:twr
tbw777 wants to merge 1 commit intoapache:masterfrom
tbw777:twr
Conversation
…tream and ErrorStream. There is no needed to make local variables as null and opening unused streams to close them later.
Member
|
My only concern here is that the method will now fail if anything goes wrong closing streams. This is a change in behavior that we do not test apparently. This could be considered reasonable if other processes try to use the same resources but I am not 100% sure. What do others think? |
Author
|
@garydgregory |
Member
|
Hm, two behavior might be the same indeed. I'll look again in the AM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tream and ErrorStream.
There is no needed to make local variables as null and opening unused streams to close them later.