Skip to content

Clean BufferedFileChannelInputStream's direct ByteBuffer once#854

Merged
garydgregory merged 1 commit into
apache:masterfrom
garydgregory:fix/BufferedFileChannelInputStream_clean
May 31, 2026
Merged

Clean BufferedFileChannelInputStream's direct ByteBuffer once#854
garydgregory merged 1 commit into
apache:masterfrom
garydgregory:fix/BufferedFileChannelInputStream_clean

Conversation

@garydgregory
Copy link
Copy Markdown
Member

Clean BufferedFileChannelInputStream's direct ByteBuffer once.

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create the first cut of the unit test.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

once

The buffer is now cleaned only on the first close() call.
@garydgregory garydgregory force-pushed the fix/BufferedFileChannelInputStream_clean branch from 024c114 to 60685d0 Compare May 31, 2026 12:39
@garydgregory garydgregory merged commit 4570048 into apache:master May 31, 2026
21 checks passed
@garydgregory garydgregory deleted the fix/BufferedFileChannelInputStream_clean branch May 31, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant