Fix PA_PUBLIC_PRIMITIVE_ATTRIBUT of MuttablePair class with attribute encapsulation#1321
Closed
felipevendrami wants to merge 1 commit intoapache:masterfrom
felipevendrami:fix/mutablepair-encapsulation-left-right
Closed
Fix PA_PUBLIC_PRIMITIVE_ATTRIBUT of MuttablePair class with attribute encapsulation#1321felipevendrami wants to merge 1 commit intoapache:masterfrom felipevendrami:fix/mutablepair-encapsulation-left-right
felipevendrami wants to merge 1 commit intoapache:masterfrom
felipevendrami:fix/mutablepair-encapsulation-left-right
Conversation
Member
|
-1: This PR breaks binary compatibility. From our README file:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encapsulate fields left and right in MutablePair to improve data integrity
Description:
This pull request addresses the issue identified by SpotBugs (PA_PUBLIC_PRIMITIVE_ATTRIBUTE) regarding the "left" and "right" fields in the MutablePair class. These fields were publicly accessible, which exposed them to potential unintended modification, violating the principle of encapsulation.
Changes made:
SpotBugs Reference:
This change resolves the SpotBugs warning: PA_PUBLIC_PRIMITIVE_ATTRIBUTE
Reference: MutablePair.java:[line 138]
Why this change is important:
Encapsulating fields ensures better control over the internal state of the MutablePair object, preventing potential misuse and maintaining consistency within the class.