Skip to content

Conversation

@IcoreE
Copy link
Contributor

@IcoreE IcoreE commented Nov 26, 2025

[LANG-1794] (https://issues.apache.org/jira/browse/LANG-1794)

The current JavaDoc for RandomUtils.secure() states that it “uses an algorithms/providers specified in the securerandom.strongAlgorithms Security property.” This is misleading.

In reality:

  1. RandomUtils.secure() uses new SecureRandom() and does not consult the securerandom.strongAlgorithms property.
  2. The securerandom.strongAlgorithms property is only used by RandomUtils.secureStrong(), which internally calls SecureRandom.getInstanceStrong() to select a strong algorithm from the configured security providers
image

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory garydgregory changed the title [LANG-1794] Fix Javadoc for RandomUtils.secure() incorrectly mentions securerandom.strongAlgorithms [LANG-1794] Fix Javadoc for RandomUtils.secure(), it incorrectly mentions securerandom.strongAlgorithms Nov 26, 2025
@garydgregory garydgregory merged commit 9eb5d09 into apache:master Nov 26, 2025
19 of 20 checks passed
garydgregory added a commit that referenced this pull request Nov 26, 2025
@garydgregory
Copy link
Member

@IcoreE
Thank you for the PR. Merged.

@IcoreE IcoreE deleted the LANG-1794-Fix-RandomUtils-secure branch December 4, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants