Fix boundary check in StrMatcher.isMatch for bufferStart #1565
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garydgregory
requested changes
Jan 12, 2026
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
Hello @SivaPA08
-1:
There are no tests to match your main changes. The description says:
"Fixes the Javadoc description of StrMatcher bufferStart and bufferEnd.": That's NOT what this PR does.
"No production code changes.": The PR changes main.
SivaPA08
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the implementation only verified that (pos + len) did not exceed
bufferEnd, but it did not check whether pos was less than bufferStart.
Now it explicitly returns 0 when pos < bufferStart.
User may pass a buffer slice with a non-zero start offset or pos lesser than bufferStart. This change enforces the logical bounds of the buffer window .