Skip to content

Conversation

@Sara-77163
Copy link

Hello @garydgregory

This PR addresses LANG-1651: https://issues.apache.org/jira/projects/LANG/issues/LANG-1651?filter=allopenissues

This PR adds a new utility method FieldUtils.isPublicStaticFinal(Field)
and corresponding unit tests.

The method checks whether a Field has public, static and final modifiers,
which is useful when identifying constant-like fields via reflection.

This utility centralizes a commonly repeated reflection check, improving readability,
avoiding duplicated modifier logic, and aligning with existing helpers in FieldUtils.
It can be used, for example, when scanning classes via reflection to identify public constants.

All tests pass locally using mvn.

  • [v] Read the contribution guidelines for this project.
  • [v] Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • [] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • [v] Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • [v] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • [v] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [v] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory
Copy link
Member

Hello @Sara-77163

Thank you for your interest in the Commons project.

I think you might have missed this from the Jira ticket: "Potentially use in reflection operations". This PR doesn't make use of the new API, so it doesn't seem needed. I could be missing something of course.

@garydgregory
Copy link
Member

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants