Refactor: Replace switch statements in Conversion.java with internal HexDigit enum#1664
Closed
henriquefsousa wants to merge 1 commit into
Closed
Refactor: Replace switch statements in Conversion.java with internal HexDigit enum#1664henriquefsousa wants to merge 1 commit into
henriquefsousa wants to merge 1 commit into
Conversation
Member
|
-1: Again, change for the sake of change, changing simple code that works to more complex code. If you want to help, fix actual bugs instead of shuffling code around. There's plenty to choose from in Jira. |
Member
|
Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Conversion class contains multiple switch statements that map hexadecimal digits:
hexDigitMsb0ToBinary()hexDigitMsb0ToInt()hexDigitToBinary()intToHexDigitMsb0()This creates code duplication and violates the Open/Closed Principle. Each method has its own switch with 16 cases (0-9, A-F), making maintenance difficult.
Solution
Added a private
HexDigitenum that centralizes all hexadecimal digit mappings:CHAR_LOOKUPandNIBBLE_LOOKUP) instead of switchChanges
Conversion.javaBenefits
Testing
Related
This resolves the switch statement code smell identified in the Conversion class.