Fix MethodUtils.getMatchingMethod false ambiguity on boxed arguments#1727
Merged
garydgregory merged 1 commit intoJun 23, 2026
Merged
Conversation
garydgregory
added a commit
that referenced
this pull request
Jun 23, 2026
Member
|
Thank you @alhudz , now merged 🚀 and deployed to snapshot builds in https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-lang3/3.21.0-SNAPSHOT/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MethodUtils.getMatchingMethodranks overloads with the privatedistancehelper, which charges a flat+1for any autoboxing conversion. For a primitive argument that makesinttoIntegerandinttoNumberboth score1, so when a class declares bothf(Integer)andf(Number)the callgetMatchingMethod(cls, "f", int.class)puts two candidates in the same distance bucket and throwsIllegalStateException: Found multiple candidates, even thoughjavacresolvesf(someInt)unambiguously tof(Integer).The fix keeps the flat penalty when a primitive boxes to its exact wrapper but adds the supertype cost when it boxes to a supertype, so
inttoIntegerranks strictly belowinttoNumber.distanceis private togetMatchingMethod, so the change stays inside that resolver; the auto-unboxing direction and every existing resolution are unaffected.