Skip to content

Char utils test #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mureinik wants to merge 3 commits into from
Closed

Char utils test #293

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c00920f
Clean up if in CharUtilsTest#testIsAscii_char
mureinik Sep 30, 2017
9512d67
CharUtilsTest#testIsAscii_char loop
mureinik Sep 30, 2017
b763dec
Improve tests for CharUtils illegal usages
mureinik Sep 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/test/java/org/apache/commons/lang3/CharUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

import java.lang.reflect.Constructor;
import java.lang.reflect.Modifier;
Expand Down Expand Up @@ -84,6 +85,7 @@ public void testToChar_Character() {
assertEquals('B', CharUtils.toChar(CHARACTER_B));
try {
CharUtils.toChar((Character) null);
fail("An IllegalArgumentException should have been thrown");
} catch (final IllegalArgumentException ex) {}
}

Expand All @@ -100,9 +102,11 @@ public void testToChar_String() {
assertEquals('B', CharUtils.toChar("BA"));
try {
CharUtils.toChar((String) null);
fail("An IllegalArgumentException should have been thrown");
} catch (final IllegalArgumentException ex) {}
try {
CharUtils.toChar("");
fail("An IllegalArgumentException should have been thrown");
} catch (final IllegalArgumentException ex) {}
}

Expand All @@ -128,6 +132,7 @@ public void testToIntValue_char() {
assertEquals(9, CharUtils.toIntValue('9'));
try {
CharUtils.toIntValue('a');
fail("An IllegalArgumentException should have been thrown");
} catch (final IllegalArgumentException ex) {}
}

Expand All @@ -144,9 +149,11 @@ public void testToIntValue_Character() {
assertEquals(3, CharUtils.toIntValue(new Character('3')));
try {
CharUtils.toIntValue(null);
fail("An IllegalArgumentException should have been thrown");
} catch (final IllegalArgumentException ex) {}
try {
CharUtils.toIntValue(CHARACTER_A);
fail("An IllegalArgumentException should have been thrown");
} catch (final IllegalArgumentException ex) {}
}

Expand Down Expand Up @@ -219,12 +226,8 @@ public void testIsAscii_char() {
assertTrue(CharUtils.isAscii('\n'));
assertFalse(CharUtils.isAscii(CHAR_COPY));

for (int i = 0; i < 128; i++) {
if (i < 128) {
assertTrue(CharUtils.isAscii((char) i));
} else {
assertFalse(CharUtils.isAscii((char) i));
}
for (int i = 0; i < 255; i++) {
assertEquals(i < 128, CharUtils.isAscii((char) i));
}
}

Expand Down