Skip to content

Use @ParameterizedTest to iterate over available locales#355

Merged
asfgit merged 1 commit intoapache:masterfrom
britter:parameterized-FastDateParser_TimeZoneStrategyTest
Sep 6, 2018
Merged

Use @ParameterizedTest to iterate over available locales#355
asfgit merged 1 commit intoapache:masterfrom
britter:parameterized-FastDateParser_TimeZoneStrategyTest

Conversation

@britter
Copy link
Copy Markdown
Member

@britter britter commented Sep 5, 2018

No description provided.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 95.253% when pulling 7e44078 on britter:parameterized-FastDateParser_TimeZoneStrategyTest into bce28f9 on apache:master.

Copy link
Copy Markdown
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! Much simpler to read it. +1

@britter
Copy link
Copy Markdown
Member Author

britter commented Sep 6, 2018

I'm going to reach out to the JUnit maintainers to find out whether we can even inject zone values via parameter source.

@asfgit asfgit merged commit 7e44078 into apache:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants