Skip to content

add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap#379

Closed
apirom9 wants to merge 5 commits intoapache:masterfrom
apirom9:tasks/add-tests-for-immutable-triple
Closed

add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap#379
apirom9 wants to merge 5 commits intoapache:masterfrom
apirom9:tasks/add-tests-for-immutable-triple

Conversation

@apirom9
Copy link
Copy Markdown
Contributor

@apirom9 apirom9 commented Oct 30, 2018

add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 95.233% when pulling 29937f0 on apirom9:tasks/add-tests-for-immutable-triple into 0fcd4ce on apache:master.

@kinow
Copy link
Copy Markdown
Member

kinow commented Oct 30, 2018

@apirom9 does this pull request number #379 supersedes yours previous one, number #378? It looks to me like the tests from #378 are present in this pull request too? If so then we should close #378 to avoid confusion when reviewing & merging.

Thanks
Bruno

@apirom9
Copy link
Copy Markdown
Contributor Author

apirom9 commented Oct 31, 2018

@kinow Yes, it is. Sorry for my mistake, I already close pull request #378

Thank you
Apirom

@kinow
Copy link
Copy Markdown
Member

kinow commented Jan 8, 2019

Generated site from master branch with -Pjacoco. Then stored the site elsewhere.

Checked out pull request locally. Squashed commits into a single one. Then rebased onto master. Generated site again, now from the pull request, and confirmed coverage went up, and build still passing OK. Code looks OK, so merging.

Thanks @apirom9 !
Bruno

kinow added a commit that referenced this pull request Jan 8, 2019
This closes pr #379

Thanks to @apirom9
@kinow
Copy link
Copy Markdown
Member

kinow commented Jan 8, 2019

Merged in bf77678

@kinow kinow closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants