Adding junits for JsonToStringStyle

[RahulNagekar]

No description provided.

[coveralls]

Coverage increased (+0.3%) to 95.544% when pulling cee7cc6 on RahulNagekar:JsonToStringStyle_Junits into e0a5a4b on apache:master.

[RahulNagekar]

This is ready for merge , could we please have this handled.

[kinow]

This project is maintained by volunteers @RahulNagekar. Please be patient as maintainers can be busy or under pressure with other issues, work, life, etc.

[MarkDacek]

Can you make your arrays in the new test cases final? Also perhaps avoid using the new keyword when you don't need memory allocated at that exact moment.

Paging @chtompki for context. Should the JSON blurbs that are the expected output be final Strings as well? That's not the existing pattern, but it seems a bit odd to be concatenating to make deterministic Strings during an assert.

[chtompki]

I'm fairly indifferent about how the strings are declared as they are tests. The concatenation is a tad odd to me because it seems to be unnecessary. That said, I'm all for more tests. I say we pull this in and clean it up in master because having more tests is always a good thing.

[chtompki]

I'll try to get to this today.

[RahulNagekar]

Will post 1 more commit improving this. I am all agree with all comnents , its best to follow best practices.

[MarkDacek]

@chtompki This seems reasonable and passes both verify and checkstyle. Worth pulling in?