Skip to content

LANG-1495 Add EnumUtils getEnum() methods with default values#475

Merged
garydgregory merged 3 commits intoapache:masterfrom
vlcheong:master
Oct 28, 2019
Merged

LANG-1495 Add EnumUtils getEnum() methods with default values#475
garydgregory merged 3 commits intoapache:masterfrom
vlcheong:master

Conversation

@vlcheong
Copy link
Contributor

Add Overloading Methods getEnum and getEnumIgnoreCase To EnumUtils

@coveralls
Copy link

coveralls commented Oct 28, 2019

Coverage Status

Coverage decreased (-0.006%) to 95.357% when pulling ad44244 on vlcheong:master into 54afdb3 on apache:master.

Copy link
Contributor

@Stzx Stzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the @since tag, the new features look good, so +1

* @param enumClass the class of the enum to query, not null
* @param enumName the enum name, null returns default enum
* @param defaultEnum the default enum
* @return the enum, default enum if not found
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide a @since tag for the new method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stzx, may I know what version number should I put ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.10 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stzx, Thanks for your guidance.

@garydgregory garydgregory merged commit 4a93461 into apache:master Oct 28, 2019
@garydgregory garydgregory changed the title LANG-1495 Update EnumUtils.java LANG-1495 Add EnumUtils getEnum() methods with default values Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants