Skip to content

LANG-1521 spring clean .gitignore #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nhojpatrick wants to merge 1 commit into from
Closed

LANG-1521 spring clean .gitignore #499

nhojpatrick wants to merge 1 commit into from

Conversation

@nhojpatrick
Copy link
Contributor

@nhojpatrick nhojpatrick commented Mar 1, 2020 •
edited
Loading

@coveralls
Copy link

coveralls commented Mar 1, 2020

Coverage Status

Coverage remained the same at 95.101% when pulling 4cd5f3a on nhojpatrick:LANG-1521 into 94b3784 on apache:master.

kinow
kinow reviewed Mar 1, 2020
View reviewed changes
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine adding more items to gitignore. But in the past we had (either on GH or mailing list I think) decided to add IDE and other tools not in our build to the user global gitignore (on Linux ~/.gitignore). Let's wait to see what others think. But thanks for the PR!

@nhojpatrick
Copy link
Contributor Author

nhojpatrick commented Mar 1, 2020 •
edited
Loading

I'm fine adding more items to gitignore. But in the past we had (either on GH or mailing list I think) decided to add IDE and other tools not in our build to the user global gitignore (on Linux ~/.gitignore). Let's wait to see what others think. But thanks for the PR!

Happy to remove Operating System, or IDE specific as should be in users global .gitignore.

What every happens I'll keep the others in sync too;
apache/commons-codec#37
apache/commons-collections#134
apache/commons-io#103

@nhojpatrick nhojpatrick closed this Jun 1, 2020
@nhojpatrick nhojpatrick deleted the LANG-1521 branch June 1, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kinow kinow kinow left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nhojpatrick @coveralls @kinow