Simplify some if statements in StringUtils.#521
Merged
garydgregory merged 4 commits intoapache:masterfrom Apr 20, 2020
Merged
Conversation
Isira-Seneviratne
force-pushed
the
Simplify_StringUtils_if_statements
branch
from
560d0c2 to
a7c92a6
Compare
garydgregory
requested changes
Apr 20, 2020
| } else if (isNotEmpty(str) && EMPTY.equals(abbrevMarker) && maxWidth > 0) { | ||
| return str.substring(0, maxWidth); | ||
| } else if (isEmpty(str) || isEmpty(abbrevMarker)) { | ||
| if (isNotEmpty(str) && EMPTY.equals(abbrevMarker) && maxWidth > 0) { |
Member
There was a problem hiding this comment.
How about EMPTY.equals(abbrevMarker) -> isEmpty(abbrevMarker) ?
Contributor
Author
There was a problem hiding this comment.
That change would mean that abbrevMarker is potentially null, according to SonarLint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.