Skip to content

[LANG-1565] Change removeLastFieldSeparator to use endsWith#550

Merged
garydgregory merged 5 commits intoapache:masterfrom
xenoamess-fork:change_removeLastFieldSeparator_to_use_endsWith
Jun 14, 2020
Merged

[LANG-1565] Change removeLastFieldSeparator to use endsWith#550
garydgregory merged 5 commits intoapache:masterfrom
xenoamess-fork:change_removeLastFieldSeparator_to_use_endsWith

Conversation

@XenoAmess
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 1, 2020

Coverage Status

Coverage decreased (-0.003%) to 95.026% when pulling d3e1cda on XenoAmess:change_removeLastFieldSeparator_to_use_endsWith into 9fcd9c8 on apache:master.

@XenoAmess
Copy link
Contributor Author

or if you think StringUtils.endsWith() is low performance here, you can at least use StringBuffer.lastIndexOf.
that is both high performance and readability.
Or, you can wait for me to refine StringUtils.endWith.
I'm refining CharSequenceUtils.lastIndexOf recently, and I have a plan to refine them all.
see #535

@XenoAmess XenoAmess changed the title change_removeLastFieldSeparator_to_use_endsWith [LANG-1547] change_removeLastFieldSeparator_to_use_endsWith Jun 2, 2020
@XenoAmess XenoAmess changed the title [LANG-1547] change_removeLastFieldSeparator_to_use_endsWith [LANG-1565] change removeLastFieldSeparator to use endsWith Jun 7, 2020
@garydgregory
Copy link
Member

Please rebase.

…change_removeLastFieldSeparator_to_use_endsWith

� Conflicts:
�	src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
@XenoAmess
Copy link
Contributor Author

Please rebase.

@garydgregory done.

…change_removeLastFieldSeparator_to_use_endsWith
@garydgregory garydgregory merged commit 1406f67 into apache:master Jun 14, 2020
@garydgregory garydgregory changed the title [LANG-1565] change removeLastFieldSeparator to use endsWith [LANG-1565] Change removeLastFieldSeparator to use endsWith Jun 14, 2020
@XenoAmess XenoAmess deleted the change_removeLastFieldSeparator_to_use_endsWith branch June 16, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants