Skip to content

[LANG-1579] refine StringUtils.convertRemainingAccentCharacters #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XenoAmess wants to merge 1 commit into from
Closed

[LANG-1579] refine StringUtils.convertRemainingAccentCharacters #568

XenoAmess wants to merge 1 commit into from

Conversation

@XenoAmess
Copy link
Contributor

@XenoAmess XenoAmess commented Jun 29, 2020

as title.
reduce array copy, for two times.

@XenoAmess XenoAmess changed the title refine StringUtils.convertRemainingAccentCharacters [LANG-1579] refine StringUtils.convertRemainingAccentCharacters Jun 29, 2020
@coveralls
Copy link

coveralls commented Jun 29, 2020

Coverage Status

Coverage decreased (-0.0007%) to 94.678% when pulling b5cf43a on XenoAmess:refine_convertRemainingAccentCharacters into da0f6a8 on apache:master.

@XenoAmess
Copy link
Contributor Author

XenoAmess commented Jul 29, 2020

Hi.
I think this pr does not need jmh test.
If you still need it, I will do it, but I will just not do it until someone tell me to.

@asfgit asfgit closed this in dbe022e Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XenoAmess @coveralls