Add StringUtils.startsWithIgnoreCase#580
Closed
JeromeWolff wants to merge 2 commits intoapache:masterfrom
JeromeWolff:add-starts-with-equals-ignore-case
Closed
Add StringUtils.startsWithIgnoreCase#580JeromeWolff wants to merge 2 commits intoapache:masterfrom JeromeWolff:add-starts-with-equals-ignore-case
JeromeWolff wants to merge 2 commits intoapache:masterfrom
JeromeWolff:add-starts-with-equals-ignore-case
Conversation
Member
|
I am not a fan of adding more and more "ignore case" versions of APIs. For 4.0, we could consider a new StringUtils class that has two default instances, one that is case-sensitive, the other not, which you would use like: The alternative for now might be to override the existing API with a boolean or maybe an enum that says what kind of case-sensitivity you want. Any thoughts from the community? |
Author
|
Yes, that's a very good suggestion. I wonder why I wrote equalsIgnoreCase several times instead of ignoreCase. |
Author
|
I have overlooked the fact that such a method already exists. Therefore I close this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the name of the method says: This method is the same as String.startsWith except that it is case insensitive.