LANG-1118: Fix StringUtils.repeat(char, int)#72
Closed
rikles wants to merge 2 commits intoapache:masterfrom
Closed
LANG-1118: Fix StringUtils.repeat(char, int)#72rikles wants to merge 2 commits intoapache:masterfrom
rikles wants to merge 2 commits intoapache:masterfrom
Conversation
added 2 commits
April 28, 2015 19:29
…king dealing with negative repeat value
Member
|
Hello @rikles I'm still trying to find out how to correctly merge PRs from the command line. Looks like it didn't work with this PR. Your changes have been merged. Can you close this PR please? :) Thank you! |
Member
Author
|
Merged into master. Close PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close PR #68. Recreated due to rebase on master.
Now doing what is said in JavaDoc comment :
when passing a negative repeat value to the StringUtils.repeat(char, int) function, it returns an empty String instead of throwing a NegativeArraySizeException.