LANG-1664: Fix javadoc (separator is a character, not a string)#779
Closed
oneiros-de wants to merge 1 commit intoapache:masterfrom
Closed
LANG-1664: Fix javadoc (separator is a character, not a string)#779oneiros-de wants to merge 1 commit intoapache:masterfrom
oneiros-de wants to merge 1 commit intoapache:masterfrom
Conversation
garydgregory
requested changes
Jul 22, 2021
| * | ||
| * @param str the String to get a substring from, may be null | ||
| * @param separator the character to search. | ||
| * @param separator the character (Unicode code point) to search for |
Member
There was a problem hiding this comment.
Sentences should end in a period. Sentences feel quite awkward (to me) ending in a preposition.
| * | ||
| * @param str the String to get a substring from, may be null | ||
| * @param separator the String to search for, may be null | ||
| * @param separator the character (Unicode code point) to search for |
Member
There was a problem hiding this comment.
Why did you remove the documentation for null input?
| * | ||
| * @param str the String to get a substring from, may be null | ||
| * @param separator the String to search for, may be null | ||
| * @param separator the character (Unicode code point) to search for |
Member
There was a problem hiding this comment.
Why did you remove the documentation for null input?
Member
|
Closing, no action since July. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the javadoc for LANG-1664.