LANG-1603: Deprecate Fraction class#935
Closed
rednikeeg wants to merge 3 commits intoapache:masterfrom
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
============================================
- Coverage 92.01% 92.00% -0.02%
+ Complexity 7436 7434 -2
============================================
Files 189 189
Lines 15751 15751
Branches 2961 2961
============================================
- Hits 14494 14491 -3
- Misses 672 673 +1
- Partials 585 587 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
The discussion in https://issues.apache.org/jira/browse/LANG-1603 does not make it clear (to me) if the proposed replacement is convenient enough. |
garydgregory
requested changes
Oct 8, 2022
| * based and thus suffers from various overflow issues. For a BigInteger based | ||
| * equivalent, please see the Commons Math BigFraction class. </p> | ||
| * | ||
| * @deprecated for <a href="https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/fraction/Fraction.html">Fraction</a> |
Member
There was a problem hiding this comment.
We can't just deprecate the class without documenting how to port your current code to the other API IMO. For example, what do you do with Fraction#invert()? Each method must be documented, otherwise, it's a disservice, and everyone using the class is left having to do their own investigation and mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira issue: https://issues.apache.org/jira/browse/LANG-1603